Build_info/Unit_info: conversion to and from string maps #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
|
Do we really need to introduce this in jsoo ? With a little bit of helper in jsoo, it seems that most of this could live in wasm_of_ocaml. |
|
That should be enough, indeed. |
OlivierNicole
force-pushed
the
converge-jsoo-tip-09
branch
from
ea7aec6
to
1d7a169
Compare
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 1, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 1, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 1, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 2, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 2, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
changed the title
|
This is ready for a new review, I think |
|
Thanks! |
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 22, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Aug 28, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 3, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to ocaml-wasm/wasm_of_ocaml
that referenced
this pull request
Sep 9, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to OlivierNicole/wasm_of_ocaml
that referenced
this pull request
Sep 9, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
OlivierNicole
added a commit
to OlivierNicole/wasm_of_ocaml
that referenced
this pull request
Sep 9, 2024
This was made necessary by the changes requested in ocsigen/js_of_ocaml#1657.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml (see ocaml-wasm/wasm_of_ocaml#47).